feat: 주문 api 수정 #481

hwangdae · 2025-09-05T03:24:14Z

작업 내용

문제점 및 어려움

해결 방안

공유 사항

Summary by CodeRabbit

New Features
- Code blocks in the editor now render with syntax highlighting.
Bug Fixes
- Order details fetch is more reliable by using a full API URL.
- Bank dropdown selection now correctly matches the displayed label.
- Booth update flow returns accurate error messages.
- Popular menu thumbnails consistently fill their containers.
Style
- Polished thumbnail image rendering to avoid letterboxing.
Chores
- Updated underlying libraries to support syntax highlighting.

fix: 통계페이지 메뉴이미지 잘리는 문제 수정Fix/admin/qa

feat: 주문 api 수정

coderabbitai · 2025-09-05T03:24:20Z

Caution

Review failed

The pull request is closed.

Walkthrough

Adds TipTap code-block-lowlight and related deps to package management (.pnp.cjs, package.json). Tweaks UI components (image sizing, comment cleanup). Adjusts AdminBooth error handling/logging. Fixes bank value-label mapping. Switches getOrderDetails to use absolute API_URI.

Changes

Cohort / File(s)	Summary
Deps: TipTap lowlight integration `package.json`, `.pnp.cjs`	Adds `@tiptap/extension-code-block-lowlight`, `highlight.js`, `lowlight` and updates Yarn PnP runtime entries, peers, and resolutions.
Admin Analytics UI tweaks `apps/nowait-admin/src/pages/AdminAnalytics/components/HeaderStatus.tsx`, `apps/nowait-admin/src/pages/AdminAnalytics/components/SalesCard.tsx`	Image thumbnail now fills container via `h-full w-full object-cover`; removes two unused commented-out state lines.
Admin Booth updates `apps/nowait-admin/src/pages/AdminBooth/AdminBooth.tsx`	onError now rejects with actual error; logging switched to `console.log`; removed comments.
Admin Booth components `apps/nowait-admin/src/pages/AdminBooth/components/AccountPage.tsx`, `apps/nowait-admin/src/pages/AdminBooth/components/DropDown/DropDownSelect.tsx`	Maps bank value "IBK기업" to label "IBK 기업" for selection; whitespace-only newline in dropdown map loop.
User API: order details URL `apps/nowait-user/src/api/order.ts`	`getOrderDetails` now calls `${API_URI}/orders/items/${publicCode}/${tableId}` instead of relative path.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor U as User
  participant App as nowait-user App
  participant API as Backend API

  U->>App: View order details
  App->>API: GET ${API_URI}/orders/items/{publicCode}/{tableId}
  API-->>App: 200 OK / Error
  App-->>U: Render order details or show error

sequenceDiagram
  autonumber
  actor Admin as Admin
  participant Booth as AdminBooth.tsx
  participant Svc as Booth Update Service

  Admin->>Booth: Save booth changes
  Booth->>Svc: updateBooth()
  alt Success
    Svc-->>Booth: resolve
    Booth-->>Admin: Success flow
  else Error
    Svc-->>Booth: reject(err)
    Booth->>Booth: onError rejects with err (raw)
    Booth->>Booth: console.log(e, "부스정보저장 에러메세지")
    Booth-->>Admin: Error handling
  end

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

feat: 오더 페이지 수정 #476 — Also updates apps/nowait-user/src/api/order.ts to use API_URI in getOrderDetails.
fix: 주문내역 확인 코드 생성 #468 — Touches the same getOrderDetails URL construction but in the opposite direction.
Develop 변경사항 반영 #258 — Modifies .pnp.cjs RAW_RUNTIME_STATE with new package/resolution entries, similar dependency-state changes.

Suggested reviewers

oriNuguri25
dgKim1

Poem

In burrows of code I hop and write,
Lowlight glows—syntax bright.
Orders fetch from URI true,
Booths now tell their honest view.
Banks align, dropdowns sigh—
A rabbit taps deploy and fly. 🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

MCP integration is disabled by default for public repositories
Jira integration is disabled by default for public repositories
Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between d67a04f and 63574ba.

⛔ Files ignored due to path filters (6)

.yarn/cache/@types-unist-npm-3.0.3-1c20461f2e-2b1e4adcab.zip is excluded by !**/.yarn/**, !**/*.zip
.yarn/cache/dequal-npm-2.0.3-53a630c60e-f98860cdf5.zip is excluded by !**/.yarn/**, !**/*.zip
.yarn/cache/devlop-npm-1.1.0-d4a98d724c-e0928ab8f9.zip is excluded by !**/.yarn/**, !**/*.zip
.yarn/cache/highlight.js-npm-11.11.1-1afef66f5e-40f53ac19d.zip is excluded by !**/.yarn/**, !**/*.zip
.yarn/cache/lowlight-npm-3.3.0-db2122ba38-9b796fa844.zip is excluded by !**/.yarn/**, !**/*.zip
yarn.lock is excluded by !**/yarn.lock, !**/*.lock

📒 Files selected for processing (8)

.pnp.cjs (11 hunks)
apps/nowait-admin/src/pages/AdminAnalytics/components/HeaderStatus.tsx (1 hunks)
apps/nowait-admin/src/pages/AdminAnalytics/components/SalesCard.tsx (0 hunks)
apps/nowait-admin/src/pages/AdminBooth/AdminBooth.tsx (4 hunks)
apps/nowait-admin/src/pages/AdminBooth/components/AccountPage.tsx (1 hunks)
apps/nowait-admin/src/pages/AdminBooth/components/DropDown/DropDownSelect.tsx (1 hunks)
apps/nowait-user/src/api/order.ts (1 hunks)
package.json (2 hunks)

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

Visit our Status Page to check the current availability of CodeRabbit.
Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

dgKim1 and others added 5 commits September 4, 2025 23:55

fix: ibk 계좌 띄어쓰기 문제 수정:

4bda300

fix: 통계페이지 메뉴이미지 잘리는 문제 수정

64c933d

Merge pull request #479 from GTable/fix/admin/qa

faca5dd

fix: 통계페이지 메뉴이미지 잘리는 문제 수정Fix/admin/qa

feat: 주문 api 수정

e604160

Merge pull request #480 from GTable/feature/user/order

63574ba

feat: 주문 api 수정

hwangdae merged commit 8aed866 into main Sep 5, 2025
2 of 3 checks passed

github-actions bot requested a review from dgKim1 September 5, 2025 03:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: 주문 api 수정 #481

feat: 주문 api 수정 #481

Uh oh!

hwangdae commented Sep 5, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Sep 5, 2025 •

edited

Loading

Review failed

Chat

Support

CodeRabbit Commands (Invoked using PR/Issue comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Status, Documentation and Community

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat: 주문 api 수정 #481

feat: 주문 api 수정 #481

Uh oh!

Conversation

hwangdae commented Sep 5, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

작업 내용

문제점 및 어려움

해결 방안

공유 사항

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Sep 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR/Issue comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Status, Documentation and Community

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

hwangdae commented Sep 5, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Sep 5, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)